Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestClient.test_service_timestamps failing consistently. #1364

Merged
merged 1 commit into from
Oct 1, 2024
Merged

TestClient.test_service_timestamps failing consistently. #1364

merged 1 commit into from
Oct 1, 2024

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Oct 1, 2024 •
edited
Loading

closes #1347

note: backport all distros.

@fujitatomoya
TestClient.test_service_timestamps failing consistently.
bfbe15d 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Oct 1, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this patch with humble with,

export RMW_IMPLEMENTATION=rmw_connextdds
colcon test --event-handlers console_direct+ --retest-until-fail 100 --packages-select rclpy --ctest-args -R test_client

and failure never happened.

@ahcorde
Copy link
Contributor

ahcorde commented Oct 1, 2024

Pulls: #1364
Gist: https://gist.githubusercontent.com/ahcorde/96c6269a7dad58feb3b1d06b554a5ca2/raw/9c8a427a054561420a1eaed75ce79d398061f292/ros2.repos
BUILD args: --packages-up-to rclpy --packages-above-and-dependencies rclpy
TEST args: --packages-select rclpy --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14636

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 7f9a307 into rolling Oct 1, 2024
3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/issue-1347 branch October 1, 2024 13:19
@ahcorde
Copy link
Contributor

ahcorde commented Oct 1, 2024

@fujitatomoya should we backport this to other distros?

@fujitatomoya
Copy link
Collaborator Author

@ahcorde yeah definitely, original issue is for humble. i will manage the backports. thanks!

@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport humble iron jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 1, 2024 •
edited
Loading

backport humble iron jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@fujitatomoya @mergify
TestClient.test_service_timestamps failing consistently. (#1364)
12e8be4 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f9a307)
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@fujitatomoya @mergify
TestClient.test_service_timestamps failing consistently. (#1364)
0ef89d2 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f9a307)
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@fujitatomoya @mergify
TestClient.test_service_timestamps failing consistently. (#1364)
cb91a5e 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f9a307)
This was referenced Oct 1, 2024
Merged
Merged
Merged
ahcorde pushed a commit that referenced this pull request Oct 1, 2024
@mergify @fujitatomoya
TestClient.test_service_timestamps failing consistently. (#1364) (#1367)
c43d4bb 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f9a307)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
ahcorde pushed a commit that referenced this pull request Oct 1, 2024
@mergify @fujitatomoya
TestClient.test_service_timestamps failing consistently. (#1364) (#1366)
5a66f92 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f9a307)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
ahcorde pushed a commit that referenced this pull request Oct 1, 2024
@mergify @fujitatomoya
TestClient.test_service_timestamps failing consistently. (#1364) (#1365)
d387309 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f9a307)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 Humble TestClient.test_service_timestamps failing consistently in Connext
2 participants
@fujitatomoya @ahcorde